Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source checking when parsing {{~!~}} and the like. #1430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

navels
Copy link

@navels navels commented May 26, 2023

This fixes a warning that derives from several of these statements in ember-prism, which are intended to strip whitespace without otherwise doing anything:

{{~! ~}}

Presently these result in a compiler warning when building ember-prism or any addon which consumes it:

unexpectedly found "! ~" when slicing source, but expected " "
unexpectedly found "! ~" when slicing source, but expected " "
unexpectedly found "! ~" when slicing source, but expected " "
unexpectedly found "! ~" when slicing source, but expected " "

Fixes one cause of emberjs/ember.js#19392

When fixing this I decided some tests would be nice to add even though they don't cover this fix. Not really thinking it is worth a test specifically targeting this case, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant