Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Component Manager version 3.4 #1328

Merged
merged 1 commit into from Aug 25, 2021
Merged

Remove deprecated Component Manager version 3.4 #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/@glimmer/manager/lib/public/component.ts
View file
Open in desktop
Expand Up @@ -43,15 +43,11 @@ export function componentCapabilities<Version extends keyof ComponentCapabilitie
managerAPI: Version,
options: ComponentCapabilitiesVersions[Version] = {}
): ComponentCapabilities {
if (DEBUG && managerAPI !== '3.4' && managerAPI !== '3.13') {
if (DEBUG && managerAPI !== '3.13') {
throw new Error('Invalid component manager compatibility specified');
}

let updateHook = true;

if (managerAPI === '3.13') {
updateHook = Boolean((options as ComponentCapabilitiesVersions['3.13']).updateHook);
}
let updateHook = Boolean((options as ComponentCapabilitiesVersions['3.13']).updateHook);

return buildCapabilities({
asyncLifeCycleCallbacks: Boolean(options.asyncLifecycleCallbacks),
Expand Down