Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested calls to helpers in dynamic helpers #1293

Merged
merged 1 commit into from Apr 15, 2021
Merged

Fix nested calls to helpers in dynamic helpers #1293

merged 1 commit into from Apr 15, 2021

Commits on Apr 1, 2021

  1. Fix nested calls to helpers in dynamic helpers 

    Currently, nested calls to helpers in dynamic helpers cause problems
because the nested helper overwrites the register that we were using to
pass along the helper definition. This is actually a worse way of doing
something that the `Dup` opcode is designed to do anyways, so I updated
to do that, following the same pattern in DynamicModifiers. Added tests
for both dynamic helpers and modifiers with nested helpers.
    Chris Garrett committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    b832ff2 View commit details
    Browse the repository at this point in the history