Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for nextSibling for partial rehydration #1180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chiragpat
Copy link
Contributor

Putting up a draft PR for supporting nextSibling use cases for partial rehydration. I am not sure we want to do this before a refactoring of element builders but putting up a draft for future reference.

Why
With partial rehydration we need to be able to let the rehydrate builder which particular component in the container is being rehydrated. This can be achieved by passing a nextSibling in the initial cursor to the renderComponent call

How

  • Modify rehydrate builder to walk backwards from the nextSibling to find the first closing block
  • Then walk backwards from there to find the first opening block at the same depth

@NullVoxPopuli
Copy link
Contributor

Is this still worth pursuing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants