Support integers as status codes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took a bit of digging but dtolnay was able to figure out how to support allowing both strings and integers for status codes. This means that we can now parse OpenAPI specs that are written in a more lenient way, i.e. without a bunch of quotes in YAML. Since all the fixtures are real specs (AFAICT), I didn't want to change them and only added unit tests.
JamesHinshelwood
pushed a commit
to JamesHinshelwood/openapiv3
that referenced
this pull request
Aug 27, 2021
…atus Support integers as status codes
JamesHinshelwood
pushed a commit
to JamesHinshelwood/openapiv3
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a bit of digging but dtolnay was able to figure out how to support
allowing both strings and integers for status codes. This means that we
can now parse OpenAPI specs that are written in a more lenient way, i.e.
without a bunch of quotes in YAML.
Since all the fixtures are real specs (AFAICT), I didn't want to change
them and only added unit tests.