Merge pull request #245 from gjtorikian/dont-do-this

Move debug gems into test env
gjtorikian · Jul 24, 2023 · 08389d3 · 08389d3
2 parents 527f487 + 7ee76b2
commit 08389d3
Show file tree

Hide file tree

Showing 20 changed files with 13 additions and 15 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,3 +1,6 @@
 {
   "rust-analyzer.checkOnSave.command": "clippy",
+  "[ruby]": {
+    "editor.defaultFormatter": "Shopify.ruby-lsp"
+  }
 }
diff --git a/Gemfile b/Gemfile
@@ -7,7 +7,7 @@ gemspec
 gem "github_changelog_generator", "~> 1.16"
 
 group :debug do
-  gem "awesome_print"
+  gem "amazing_print"
   gem "debug"
 end
 

diff --git a/Rakefile b/Rakefile
@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 
-if ENV.fetch("DEBUG", false)
-  require "awesome_print"
-  require "debug"
-end
-
 # Gem Spec
 require "bundler"
 COMMONMARKER_SPEC = Bundler.load_gemspec("commonmarker.gemspec")

diff --git a/lib/commonmarker.rb b/lib/commonmarker.rb
@@ -7,11 +7,6 @@
 require "commonmarker/renderer"
 require "commonmarker/version"
 
-if ENV.fetch("DEBUG", false)
-  require "awesome_print"
-  require "debug"
-end
-
 module Commonmarker
   class << self
     # Public: Parses a CommonMark string into an HTML string.

diff --git a/lib/commonmarker/config.rb b/lib/commonmarker/config.rb
@@ -79,7 +79,7 @@ def process_plugins(plugins)
 
     [:syntax_highlighter].each do |type|
       define_singleton_method :"process_#{type}_plugin" do |plugin|
-        return nil if plugin.nil? # plugin explicitly nil, remove it
+        return if plugin.nil? # plugin explicitly nil, remove it
 
         Commonmarker::Config::PLUGINS[type].each_with_object({}) do |(key, value), hash|
           if plugin.nil? # option not provided, go for the default

diff --git a/lib/commonmarker/version.rb b/lib/commonmarker/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Commonmarker
-  VERSION = "1.0.0.pre9"
+  VERSION = "1.0.0.pre10"
 end
diff --git a/rakelib/test.rake b/rakelib/test.rake
@@ -5,7 +5,7 @@ require "rake/testtask"
 Rake::TestTask.new("test") do |t|
   t.libs << "lib"
   t.libs << "test"
-  t.pattern = "test/test_*.rb"
+  t.pattern = "test/**/*_test.rb"
   t.verbose = true
   t.warning = false
 end
diff --git a/test/test_basics.rb → test/basics_test.rb b/test/test_basics.rb → test/basics_test.rb
diff --git a/test/test_encoding.rb → test/encoding_test.rb b/test/test_encoding.rb → test/encoding_test.rb
diff --git a/test/test_extensions.rb → test/extensions_test.rb b/test/test_extensions.rb → test/extensions_test.rb
@@ -46,7 +46,7 @@ def test_definition_lists
       : Ruby wrapper for comrak (CommonMark parser)
     MARKDOWN
 
-    extensions = { strikethrough: false,  description_lists: true }
+    extensions = { strikethrough: false, description_lists: true }
     options = { extension: extensions, render: { hardbreaks: false } }
     output = Commonmarker.to_html(markdown, options: options)
 

diff --git a/test/test_footnotes.rb → test/footnotes_test.rb b/test/test_footnotes.rb → test/footnotes_test.rb
diff --git a/test/test_frontmatter.rb → test/frontmatter_test.rb b/test/test_frontmatter.rb → test/frontmatter_test.rb
diff --git a/test/test_linebreaks.rb → test/linebreaks_test.rb b/test/test_linebreaks.rb → test/linebreaks_test.rb
diff --git a/test/test_maliciousness.rb → test/maliciousness_test.rb b/test/test_maliciousness.rb → test/maliciousness_test.rb
diff --git a/test/test_pathological_inputs.rb → test/pathological_inputs_test.rb b/test/test_pathological_inputs.rb → test/pathological_inputs_test.rb
diff --git a/test/test_smartpunct.rb → test/smartpunct_test.rb b/test/test_smartpunct.rb → test/smartpunct_test.rb
diff --git a/test/test_spec.rb → test/spec_test.rb b/test/test_spec.rb → test/spec_test.rb
diff --git a/test/test_syntax_highlighting.rb → test/syntax_highlighting_test.rb b/test/test_syntax_highlighting.rb → test/syntax_highlighting_test.rb
diff --git a/test/test_tasklists.rb → test/tasklists_test.rb b/test/test_tasklists.rb → test/tasklists_test.rb
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -5,6 +5,11 @@
 require "minitest/pride"
 require "minitest/focus"
 
+if ENV.fetch("DEBUG", false)
+  require "amazing_print"
+  require "debug"
+end
+
 include Commonmarker
 
 FIXTURES_DIR = File.join(File.dirname(__FILE__), "fixtures")