Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GeertJohan/go.rice to v1.0.3 #64

Merged
merged 1 commit into from Mar 7, 2023

Conversation

azanar
Copy link
Contributor

@azanar azanar commented Feb 4, 2023

Description

Upgrade GeertJohan/go.rice to v1.0.3.

This upgrade resolves an panic-causing incompatibility between go.rice prior to v1.0.3 and go subsequent to 1.18.

More details on the issue and related PR to go.rice here: GeertJohan/go.rice#177

The panic in that issue is the same panic I see when running an unpatched dazzle.

More Details

The issue ultimately caused by an issue in go.zipexe, which is depended upon by go.rice. More details on the go.zipexe issue here: daaku/go.zipexe#6

How to test

  • Expected behavior:
  1. Run go build
  2. ./dazzle
  3. See usage.
  • Unpatched behavior:
  1. Run go build
  2. ./dazzle
  3. See panic.

Release Notes

* Fix panic when running `dazzle` compiled by go1.19 or later compiler.

Documentation

No documentation update needed. 😄

@azanar azanar marked this pull request as ready for review February 4, 2023 21:53
@azanar azanar requested a review from a team February 4, 2023 21:53
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #64 (2c0348b) into main (27c1d52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   51.65%   51.65%           
=======================================
  Files           4        4           
  Lines         908      908           
=======================================
  Hits          469      469           
  Misses        331      331           
  Partials      108      108           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kylos101
Copy link
Contributor

kylos101 commented Mar 7, 2023

Dear @azanar , thank you so much for sharing! 🙌 My apologies for the delay in approval/review. Have a nice day!

Works like a champ:

gitpod /workspace/dazzle (upgrade_go_rice) $ ./dazzle
Dazzle breaks your usual Docker build by separating the layers. The idea is that
this way we can avoid needless cache invalidation.

THIS IS AN EXPERIEMENT. THINGS WILL BREAK. BEWARE.

Usage:
  dazzle [command]

Available Commands:
  build       Builds a Docker image with independent layers
  combine     Combines previously built chunks into a single image
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  project     describes, debugs and configures a dazzle project
  version     Prints the dazzling version

Flags:
      --addr string      address of buildkitd (default "unix:///run/buildkit/buildkitd.sock")
      --context string   context path (default "/workspace/dazzle")
  -h, --help             help for dazzle
  -v, --verbose          enable verbose logging

Use "dazzle [command] --help" for more information about a command.

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👍 👍

@kylos101 kylos101 merged commit 1108889 into gitpod-io:main Mar 7, 2023
@azanar azanar deleted the upgrade_go_rice branch March 12, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants