Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance exception tests #148

Merged
merged 1 commit into from Oct 25, 2019
Merged

Enhance exception tests #148

merged 1 commit into from Oct 25, 2019

Conversation

peter279k
Copy link
Contributor

Changed log

  • To support future PHPUnit 8.x versions about deprecated @expectedException warning message, using the expectException and expectExceptionMessage instead.
  • Removing unused variables.

The deprecated warning message is as follows:

 with data set "empty string" ('')
The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageRegExp() instead.

The related issue is available here.

@alexandresalome
Copy link
Member

Thanks for taking care of testsuite.

@GrahamCampbell
Copy link
Member

Excellent, thanks. 🚀

@GrahamCampbell GrahamCampbell merged commit 4b9314e into gitonomy:master Oct 25, 2019
@peter279k peter279k deleted the enhance_exceptions branch October 26, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandresalome alexandresalome alexandresalome approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peter279k @alexandresalome @GrahamCampbell