Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple.toml #1393

Closed
wants to merge 2 commits into from
Closed

Update simple.toml #1393

wants to merge 2 commits into from

Conversation

fhverga
Copy link

@fhverga fhverga commented Apr 18, 2024

Contribution to a scenario of "passwords" exposed for authentication in MSSQL Banks where by default the scenario below was not identified. Hence the proposed contribution.

{
"Microsoft.Hosting.Lifetime": "Information"
}
{
"AllowedHosts": "*",
"ConnectionStrings": {
"ContextLocal": "Data Source=(localdb)\MSSQLLocalDB;Initial Catalog=projetoX;Integrated Security=True;Connect Timeout=30;Encrypt=False;TrustServerCertificate=False;ApplicationIntent=ReadWrite;MultiSubnetFailover=False",
"ContextQa": "Server=xyzqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcabc;Password=A#$dDa41eUhbdbd;",
"ContextProd": "Server=xyzprod01.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcdef;Password=@@dqeddadfg;",
"ContextQa02": "Server=xyzqlqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcfgh;Password=AYDAJOAJjjjH;"
}
}

Description:

Explain the purpose of the PR.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

Contribution to a scenario of "passwords" exposed for authentication in MSSQL Banks where by default the scenario below was not identified. Hence the proposed contribution.

{
"Microsoft.Hosting.Lifetime": "Information"
}
{
  "AllowedHosts": "*",
  "ConnectionStrings": {
    "ContextLocal": "Data Source=(localdb)\\MSSQLLocalDB;Initial Catalog=projetoX;Integrated Security=True;Connect Timeout=30;Encrypt=False;TrustServerCertificate=False;ApplicationIntent=ReadWrite;MultiSubnetFailover=False",
    "ContextQa": "Server=xyzqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcabc;Password=A#$dDa41eUhbdbd;",
    "ContextProd": "Server=xyzprod01.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcdef;Password=@@dqeddadfg;",
    "ContextQa02": "Server=xyzqlqa.offsec.us-east-1.rds.amazonaws.com;Database=xproject;User Id=svcfgh;Password=AYDAJOAJjjjH;"
  }
}
fix in rule structure to accept regex for MSSQL passwords
@rgmz
Copy link
Contributor

rgmz commented Apr 18, 2024

If this is meant to be a new rule, it has to be created under cmd/generate/config/rules/.
https://github.com/gitleaks/gitleaks/blob/master/CONTRIBUTING.md#adding-new-gitleaks-rules

@fhverga
Copy link
Author

fhverga commented Apr 18, 2024

@rgmz thanks for support
I'm trying to adjust my rule there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants