fix: reduce false positives by hashicorp #1358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baruchiro
pushed a commit
to Checkmarx/2ms
that referenced
this pull request
Feb 29, 2024
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Feb 29, 2024
I didn't know it when I made gitleaks#1358
added 2 commits
March 6, 2024 11:12
on-behalf-of: @Checkmarx <baruch.odem@checkmarx.com>
3 tasks
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
### Description: To add this rule I took examples from the official Hashicorp documentation, but now I used this rule and it find too generic cases such as `const TagPassword = "password"`. Using the `Entropy` field is a balance between true/false positives, since with `3.5` it will ignore almost all passwords less then 10 characters length. ### Checklist: * [x] Does your PR pass tests? * [x] Have you written new tests for your changes? * [x] Have you lint your code locally prior to submission? Original: gitleaks#1358
zricethezav
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Refactor Scalingo API token regex and add sample token * improve docs for allowlist I didn't know it when I made #1358 --------- Co-authored-by: Baruch Odem <baruch.odem@checkmarx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To add this rule I took examples from the official Hashicorp documentation, but now I used this rule and it find too generic cases such as
const TagPassword = "password".Using the
Entropyfield is a balance between true/false positives, since with3.5it will ignore almost all passwords less then 10 characters length.Checklist: