add support for Azure Data Factory SHIR Key #1327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zricethezav , did you have the chance to check this PR |
zricethezav
reviewed
Jan 24, 2024
| RuleID: "datafactory-shir-token", | ||
| // SHIR Key format: IR@{GUID}@{string_azure _resource_name}@{string_azure_resource_location}@{string_base64} | ||
| Regex: generateUniqueTokenRegex(`IR@[0-9a-zA-Z-]{36}@(.*?)@[0-9a-zA-Z\-=]*@[A-Za-z0-9+\/=]{44}`, false), | ||
| Keywords: []string{"IR"}, |
There was a problem hiding this comment.
@RachidAZ Could IR become IR@ or is the @ not guaranteed?
There was a problem hiding this comment.
@zricethezav I am not sure whether @ is guaranteed, "IR" should do the job :)
There was a problem hiding this comment.
More specificity ensures better performance. Please replace IR with IR@ otherwise we could see a significant performance hit since IR is going to trigger lots of regex checks
There was a problem hiding this comment.
@zricethezav makes sense, updated. Thanks.
|
Hello @zricethezav , any chance to merge this? Thanks |
|
@zricethezav 2 months since the latest changes, could you please help to merge this? Appreciate your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR will detect the Azure Data Factory Self-Hosted Integration Runtime Key, that is used to configure the desktop client that will receive the commands and the data from the ADF control plane to be processed.
details about this service can be found here: https://learn.microsoft.com/en-us/azure/data-factory/create-self-hosted-integration-runtime?tabs=data-factory#install-and-register-a-self-hosted-ir-from-microsoft-download-center
SHIR Key format: IR@{GUID}@{string_azure _resource_name}@{string_azure_resource_location}@{string_base64}
Checklist: