feat: catch JSON stringified #1267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd recommend making the escape slash more repeatable than other symbols. I've encountered several instances of nested escaped JSON, which does not get detected otherwise. |
|
@rgmz Give me an example and I will TDD it :-) |
3 tasks
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
### Description:
I have a code sample when someone writting a hard-coded JSON as string,
and it looks like this:
```java
var json = "{ \"access-key\": \"access key here\" }"
```
### Checklist:
* [x] Does your PR pass tests?
* [x] Have you written new tests for your changes?
* [x] Have you lint your code locally prior to submission?
Original: gitleaks#1267
baruchiro
force-pushed
the
json-as-string
branch
from
59b89ea
to
6983691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have a code sample when someone writting a hard-coded JSON as string, and it looks like this:
Checklist: