feat: catch secret in XML child #1265
Open
+139
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Sep 11, 2023
| @@ -27,7 +27,7 @@ const ( | |||
| // \x60 = ` | |||
| secretPrefixUnique = `\b(` | |||
| secretPrefix = `(?:'|\"|\s|=|\x60){0,5}(` | |||
| secretSuffix = `)(?:['|\"|\n|\r|\s|\x60|;]|$)` | |||
| secretSuffix = `)(?:['|\"|\n|\r|\s|\x60|;|<]|$)` | |||
There was a problem hiding this comment.
Minor nitpic: since this part is enclosed in [], the pipes aren't necessary.
It could simply be: (assuming we don't actually want to match on pipes)
(?:['\"\n\r\s\x60;<]|$)
There was a problem hiding this comment.
Changed it in another PR: #1266
baruchiro
force-pushed
the
general-rule
branch
from
1b28156
to
4d1e5e3
Compare
This was referenced Sep 11, 2023
This was referenced Mar 28, 2024
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
### Description: - Added generic API key inside an XML element: `<password>edf8f16608465858a6c9e3cccb97d3c2</password>` - Added True-Positives and False-Positives to the Generic API Key rule ### Checklist: * [x] Does your PR pass tests? * [x] Have you written new tests for your changes? * [x] Have you lint your code locally prior to submission? Original: gitleaks#1265
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
### Description: > since this part is enclosed in `[]`, the pipes aren't necessary. _Originally posted by @rgmz in gitleaks#1265 (comment) ### Checklist: * [x] Does your PR pass tests? * [x] Have you written new tests for your changes? * [x] Have you lint your code locally prior to submission? Original: gitleaks#1266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
<password>edf8f16608465858a6c9e3cccb97d3c2</password>Checklist: