Lint Issues- Testing out addition of Check Destroy in some Acceptance Tests + other refactoring

[Shocktrooper]

Resolves #433

[timofurrer]

Can you remove the AT001 check from the provider lint check ignores:

terraform-provider-gitlab/GNUmakefile

Line 23 in 9c09272

TFPROVIDERLINTX_CHECKS = -XAT001=false -XR003=false -XS002=false

[github-actions]

This pull request has merge conflicts. Please rebase your branch onto main.

[github-actions]

Conflicts are resolved. Thank you! 😀

[Shocktrooper]

@timofurrer It appears that AT001 is different from XAT001 in the linter. Turning off XAT001 makes a massive amount of separate lint issues so leaving it for now.
https://github.com/gitlabhq/terraform-provider-gitlab/runs/5775213763?check_suite_focus=true
https://github.com/bflad/tfproviderlint/tree/main/xpasses/XAT001
https://github.com/bflad/tfproviderlint/tree/main/passes/AT001

[Shocktrooper]

@timofurrer I combed over the test case and am not sure why the Acceptance Test is failing. If you could take a look I think this is the last thing
https://github.com/gitlabhq/terraform-provider-gitlab/runs/5775393381?check_suite_focus=true#step:6:110

[Shocktrooper]

@armsnyder If you have a chance as well to take a look the issue is not apparent to me why it is failing.

[armsnyder]

Hi @Shocktrooper -- I couldn't tell what the issue was either. I assume it has to do with the new function you added to render out the Config field in each TestStep. Maybe try removing the TestSteps one by one, and running a targeted test to catch where the problem lies.

I also opened this PR to make the error more helpful in the future, not that it will help us now. 😄 hashicorp/terraform-plugin-sdk#925

[Shocktrooper]

@armsnyder I figured out what steps at least. Apparently having a completely blank resource config could be the issue from what I can tell or it was the way the anonymous function was returned in the other Not Shared check function. After looking at the test again I didn't think it was needed either because we have a check destroy function so it should all be working now :) This is all ready for review again

[timofurrer]

@Shocktrooper @armsnyder I've actually noticed that in other providers test where the have something like " " as a config to prevent this ...

[Shocktrooper]

@timofurrer interesting do you have an example of this in action as I am unsure how that would be different than what I replaced in my last commit. Also is there a point to blank configs when you have a check destroy function.

[timofurrer]

@Shocktrooper yes, here:

https://github.com/hashicorp/terraform-provider-google/blob/b5b0438689c8a10fad804bdbc59ff45afa8aeb33/google/resource_cloud_run_service_test.go#L63

[timofurrer]

LGTM 🎉

[github-actions]

This functionality has been released in v3.14.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!