Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Hook Resource and Data Sources #1221

Merged
merged 3 commits into from Aug 24, 2022
Merged

Group Hook Resource and Data Sources #1221

merged 3 commits into from Aug 24, 2022

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented Aug 19, 2022 •
edited

This change set implements:

  • gitlab_group_hook resource
  • gitlab_group_hook data source
  • gitlab_group_hooks data source

Currently blocked by:

@timofurrer timofurrer added this to the v3.17.0 milestone Aug 19, 2022
@timofurrer timofurrer self-assigned this Aug 19, 2022
@github-actions github-actions bot added data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource tests size/L labels Aug 19, 2022
@timofurrer timofurrer linked an issue Aug 19, 2022 that may be closed by this pull request
[Feature Request] Add Gitlab group webhook management #680
Closed
@github-actions github-actions bot added the merge-conflict PR cannot be merged due to a merge conflict label Aug 21, 2022
@github-actions
Copy link

This pull request has merge conflicts. Please rebase your branch onto main.

@github-actions github-actions bot removed the merge-conflict PR cannot be merged due to a merge conflict label Aug 21, 2022
@github-actions
Copy link

Conflicts are resolved. Thank you! 😀

@timofurrer timofurrer force-pushed the feature/group-hooks branch 2 times, most recently from 2778d9a to 9c4435b Compare August 22, 2022 10:37
armsnyder
armsnyder approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@timofurrer timofurrer merged commit cdab8f5 into gitlabhq:main Aug 24, 2022
@github-actions
Copy link

This functionality has been released in v3.17.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armsnyder armsnyder armsnyder approved these changes

@PatrickRice-KSC PatrickRice-KSC Awaiting requested review from PatrickRice-KSC

Assignees

@timofurrer timofurrer

Labels
data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource size/L tests
Milestone
v3.17.0
2 participants
@timofurrer @armsnyder