Adding Check Destroy to Instance Variable test and project share grou…

…p test

internal/provider/resource_gitlab_instance_variable_test.go

@@ -15,10 +15,10 @@ func TestAccGitlabInstanceVariable_basic(t *testing.T) {
 	var instanceVariable gitlab.InstanceVariable
 	rString := acctest.RandString(5)
 
-	// lintignore: AT001 // TODO: Resolve this tfproviderlint issue
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
+		CheckDestroy:      testAccCheckGitlabInstanceVariableDestroy,
 		Steps: []resource.TestStep{
 			// Create a variable with default options
 			{
@@ -120,6 +120,29 @@ func testAccCheckGitlabInstanceVariableExists(n string, instanceVariable *gitlab
 	}
 }
 
+func testAccCheckGitlabInstanceVariableDestroy(s *terraform.State) error {
+	var key string
+
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type == "gitlab_instance_variable" {
+			key = rs.Primary.ID
+		}
+	}
+
+	iv, _, err := testGitlabClient.InstanceVariables.GetVariable(key)
+	if err == nil {
+		if iv != nil {
+			return fmt.Errorf("Instance Variable %s still exists", key)
+		}
+	} else {
+		if !is404(err) {
+			return err
+		}
+	}
+
+	return nil
+}
+
 type testAccGitlabInstanceVariableExpectedAttributes struct {
 	Key       string
 	Value     string

internal/provider/resource_gitlab_project_share_group_test.go

@@ -45,10 +45,10 @@ func TestResourceGitlabProjectShareGroupStateUpgradeV0(t *testing.T) {
 func TestAccGitlabProjectShareGroup_basic(t *testing.T) {
 	randName := acctest.RandomWithPrefix("acctest")
 
-	// lintignore: AT001 // TODO: Resolve this tfproviderlint issue
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
+		CheckDestroy:      testAccCheckGitlabProjectShareGroupDestroy,
 		Steps: []resource.TestStep{
 			// Share a new project with a new group.
 			{
@@ -109,6 +109,34 @@ func testAccCheckGitlabProjectIsNotShared(projectName string) resource.TestCheck
 	}
 }
 
+func testAccCheckGitlabProjectShareGroupDestroy(s *terraform.State) error {
+	var projectId string
+	var groupId int
+	var err error
+
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type == "gitlab_project_share_group" {
+			projectId, groupId, err = projectIdAndGroupIdFromId(rs.Primary.ID)
+			if err != nil {
+				return fmt.Errorf("[ERROR] cannot get project ID and group ID from input: %v", rs.Primary.ID)
+			}
+		}
+	}
+
+	proj, _, err := testGitlabClient.Projects.GetProject(projectId, nil)
+	if err != nil {
+		return err
+	}
+
+	for _, v := range proj.SharedWithGroups {
+		if groupId == v.GroupID {
+			return fmt.Errorf("GitLab Project Share %d still exists", groupId)
+		}
+	}
+
+	return nil
+}
+
 func testAccGitlabProjectShareGroupConfig(randName, accessLevel string) string {
 	return fmt.Sprintf(`
 resource "gitlab_project" "test" {