Requested updates to SAML link resource

gitlabhq · Aug 24, 2022 · 857a9c4 · 857a9c4
1 parent ef998f2
commit 857a9c4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/docs/resources/group_saml_link.md b/docs/resources/group_saml_link.md
@@ -28,7 +28,7 @@ resource "gitlab_group_saml_link" "test" {
 
 ### Required
 
-- `access_level` (String) Access level for members of the SAML group. Valid values are: `Guest`, `Reporter`, `Developer`, `Maintainer`, `Owner`.
+- `access_level` (String) Access level for members of the SAML group. Valid values are: `guest`, `reporter`, `developer`, `maintainer`, `owner`.
 - `group` (String) The ID or path of the group to add the SAML Group Link to.
 - `saml_group_name` (String) The name of the SAML group.
 

diff --git a/internal/provider/resource_gitlab_group_saml_link.go b/internal/provider/resource_gitlab_group_saml_link.go
@@ -13,11 +13,11 @@ import (
 
 var _ = registerResource("gitlab_group_saml_link", func() *schema.Resource {
 	validGroupSamlLinkAccessLevelNames := []string{
-		"Guest",
-		"Reporter",
-		"Developer",
-		"Maintainer",
-		"Owner",
+		"guest",
+		"reporter",
+		"developer",
+		"maintainer",
+		"owner",
 	}
 
 	return &schema.Resource{

diff --git a/internal/provider/resource_gitlab_group_saml_link_test.go b/internal/provider/resource_gitlab_group_saml_link_test.go
@@ -12,6 +12,7 @@ import (
 )
 
 func TestAccGitlabGroupSamlLink_basic(t *testing.T) {
+	testAccCheckEE(t)
 	testAccRequiresAtLeast(t, "15.3")
 
 	testGroup := testAccCreateGroups(t, 1)[0]
@@ -26,7 +27,7 @@ func TestAccGitlabGroupSamlLink_basic(t *testing.T) {
 				Config: fmt.Sprintf(`
 					resource "gitlab_group_saml_link" "this" {
 						group   		= "%d"
-						access_level 	= "Developer"
+						access_level 	= "developer"
 						saml_group_name = "test_saml_group"
 
 					}
@@ -43,7 +44,7 @@ func TestAccGitlabGroupSamlLink_basic(t *testing.T) {
 				Config: fmt.Sprintf(`
 					resource "gitlab_group_saml_link" "this" {
 						group   		= "%d"
-						access_level 	= "Maintainer"
+						access_level 	= "maintainer"
 						saml_group_name = "test_saml_group"
 
 					}