Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(electron): Move off deprecated remote module #649

Merged
merged 7 commits into from Oct 9, 2023
Merged

chore(electron): Move off deprecated remote module #649

merged 7 commits into from Oct 9, 2023

Conversation

bmulholland
Copy link
Collaborator

@bmulholland bmulholland commented Oct 3, 2023 •
edited

This is a requirement for electron v14, which drops the module. We can do it before the upgrade, for smaller changes.

@bmulholland
Copy link
Collaborator Author

bmulholland commented Oct 3, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bmulholland bmulholland mentioned this pull request Oct 3, 2023
Merged
1 task
@bmulholland
Copy link
Collaborator Author

This introduces a new issue, probably on a check for isLinux: [79860:1003/134934.778674:INFO:CONSOLE(2)] "Uncaught TypeError: Cannot read property 'process' of undefined"

@bmulholland bmulholland marked this pull request as draft October 3, 2023 11:52
@bmulholland bmulholland force-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from a76fa67 to 46d82b4 Compare October 3, 2023 11:52
@bmulholland bmulholland marked this pull request as ready for review October 3, 2023 11:57
@bmulholland
Copy link
Collaborator Author

Fixed

bmulholland
bmulholland commented Oct 3, 2023
View reviewed changes
main.js Outdated Show resolved Hide resolved
@bmulholland bmulholland force-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from 32f92d6 to 81a8748 Compare October 3, 2023 14:21
@bmulholland bmulholland force-pushed the 10-03-chore_electron_Move_off_deprecated_remote_module branch from 9fbb3a3 to d756682 Compare October 3, 2023 15:19
This was referenced Oct 4, 2023
Merged
Merged
Merged
Draft
Base automatically changed from renovate/axios-1.x to main October 4, 2023 12:16
@afonsojramos afonsojramos merged commit 4d65077 into main Oct 9, 2023
6 checks passed
@afonsojramos afonsojramos deleted the 10-03-chore_electron_Move_off_deprecated_remote_module branch October 9, 2023 23:37
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmulholland @afonsojramos @setchy