Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Checks "more details" link should link to Rally #202

Open
ineffyble opened this issue Dec 4, 2020 · 12 comments
Open

Checks "more details" link should link to Rally #202

ineffyble opened this issue Dec 4, 2020 · 12 comments
Labels
O: backlog 🤖 Exempt from stale bot

Comments

@ineffyble
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a user, when I see a link at the bottom of my Checks summary, which says "View more details on Rally App", I expect that link to take me to Rally, instead of the source code of the GitHub app.

Describe the solution you'd like
Setting details_url on the Checks Run object to point to the most specific location in Rally possible (e.g. Artifact, Project, etc, falling back to the Rally dashboard).

@ineffyble ineffyble added the enhancement New feature or request label Dec 4, 2020
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@ineffyble
Copy link
Contributor Author

This should stay open.

@primetheus primetheus added O: backlog 🤖 Exempt from stale bot wontfix This will not be worked on and removed O: backlog 🤖 Exempt from stale bot enhancement New feature or request labels Jan 9, 2021
@primetheus
Copy link
Contributor

primetheus commented Jan 11, 2021

This is not something that can be achieved. The link that is generated at the bottom is part of the GitHub App installation. It's not customizable and is generated from the Homepage URL field in the GitHub App details.

@ineffyble
Copy link
Contributor Author

@primetheus The link is settable in the API call:

image

It's just not being set currently.

@ineffyble
Copy link
Contributor Author

Just needs to be added to the GitHub Checks API call you make here:

return context.github.checks.create(context.repo({
and in other places

See reference at https://docs.github.com/en/free-pro-team@latest/rest/reference/checks

@primetheus
Copy link
Contributor

Ah, right. @ineffyble in the event that you have multiple Rally artifacts in the check, what would be the desired endpoint? For example, if a pull request addresses US8 and DE22, what should the link redirect users to?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@ineffyble
Copy link
Contributor Author

@primetheus If there's a way to redirect to the a page showing a list of those artifacts (possibly by searching for "US8 OR DE22" or such), that would be ideal. Otherwise the first artifact would be fine I think.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@ineffyble
Copy link
Contributor Author

Commenting.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@zkoppert zkoppert added O: backlog 🤖 Exempt from stale bot and removed O: stale 🤖 labels Apr 15, 2021
@primetheus primetheus removed the wontfix This will not be worked on label May 7, 2021
@yeikel
Copy link

yeikel commented May 24, 2021

There is a case that we need to consider

If commentOnPull: false then the status check url should show the results of the report. Otherwise we won't have any other way to see it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
O: backlog 🤖 Exempt from stale bot
Projects
None yet
Development

No branches or pull requests

4 participants