Merge pull request #221 from github/dependabot/npm_and_yarn/js-yaml-4…

….0.0 Bump js-yaml from 3.14.0 to 4.0.0
github · Jan 9, 2021 · 668b9c1 · 668b9c1
2 parents fb7913e + 2e7088d
commit 668b9c1
Show file tree

Hide file tree

Showing 4 changed files with 89 additions and 17 deletions.
diff --git a/lib/RallyValidate.js b/lib/RallyValidate.js
@@ -119,7 +119,7 @@ class RallyValidate {
     } else {
       // Config file found, need to parse variables
       const orgConfigString = Buffer.from(orgConfigResponse.data.content, 'base64').toString('ascii')
-      orgConfig = yaml.safeLoad(orgConfigString)
+      orgConfig = yaml.load(orgConfigString)
     }
 
     return orgConfig

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
     "outdent": "^0.8.0",
     "probot": "^9.14.1",
     "rally": "^2.1.3",
-    "js-yaml": "^3.14.0"
+    "js-yaml": "^4.0.0"
   },
   "devDependencies": {
     "jest": "^26.6.3",

diff --git a/test/RallyValidate.test.js b/test/RallyValidate.test.js
@@ -21,8 +21,8 @@ describe('JiraIssueValidate', () => {
 
     handler = new RallyValidate(robot)
 
-    const configFile = yaml.safeLoad(fs.readFileSync('./rally.yml'))
-    const probotConfigEncodedYaml = Buffer.from(yaml.safeDump(configFile)).toString('base64')
+    const configFile = yaml.load(fs.readFileSync('./rally.yml'))
+    const probotConfigEncodedYaml = Buffer.from(yaml.dump(configFile)).toString('base64')
     context = {
       config: jest.fn().mockImplementation(() => Promise.resolve(configFile)),
       github: {
@@ -94,14 +94,14 @@ describe('JiraIssueValidate', () => {
 
   describe('set artifacts to complete on pr merge', () => {
     it('doesn\'t attempt a status change when mergeOnPRBody is set to false in config', async () => {
-      const configFile = yaml.safeLoad(fs.readFileSync('./rally.yml'))
+      const configFile = yaml.load(fs.readFileSync('./rally.yml'))
       configFile.mergeOnPRBody = false
       await handler.closeArtifactsFromPRBody(context, configFile, rallyClient)
       expect(rallyClient.update).not.toHaveBeenCalled()
     })
 
     it('sets status to completed when mergeOnPRBody is set to true in config', async () => {
-      const configFile = yaml.safeLoad(fs.readFileSync('./rally.yml'))
+      const configFile = yaml.load(fs.readFileSync('./rally.yml'))
       await handler.closeArtifactsFromPRBody(context, configFile, rallyClient)
       expect(rallyClient.update).toHaveBeenCalled()
     })