Add webrick as Ruby 3 doesn’t include it #914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve specified the BUNDLE_GEMFILE as the one that exists in the /src/site location (the source of the site being built) was preventing Jekyll from finding the installed dependencies.
This may be fixable by upgrading Jekyll as it is now declared as a dependency.
|
I would rather expect that the docker image uses the same ruby version by default as GitHub Pages publishing (still 2.x) |
|
Yep, me too (GHP is using Ruby 2.7.4), but it was upgraded to use 3.x in a1e407c in January. There’s a conversation in #898 where this was discussed it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752.
webrickwasn’t available it’s not bundled as of Ruby v3.0.0. I’ve resolved this by adding it to the dependencies class.