Add a script to validate all the themes we support #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
force-pushed
the
validate-themes-work
branch
from
c242352
to
49366b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #772, we removed the
jekyll-theme-<theme_name>themes from this gem and replaced them withremote_themedeclarations which are equivalent. In doing so, we accidentally broke the local development process. Folks withtheme: jekyll-theme-<theme_name>need to change to useremote_theme: pages-themes/<theme_name>@v0.2.0instead to get their site to build locally.In order to prevent future local build breakages, this PR proposes a new CI target to test building a Jekyll site with each theme.
Related to #777