Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jekyll to v3.9.0, kramdown to v2.3.0 #704

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Bump jekyll to v3.9.0, kramdown to v2.3.0 #704

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
597b140
Update jekyll to :gem: v3.9.0
hubot Aug 5, 2020
aaf0227
Upgrade to kramdown v2 and add kramdown-parser-gfm to allow GFM input
parkr Aug 5, 2020
044a9e1
Add test to ensure TeX is properly converted by kramdown
parkr Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/github-pages/dependencies.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ module GitHubPages
class Dependencies
VERSIONS = {
# Jekyll
"jekyll" => "3.8.7",
"jekyll" => "3.9.0",
"jekyll-sass-converter" => "1.5.2",

# Converters
"kramdown" => "1.17.0",
"kramdown" => "2.3.0",
"kramdown-parser-gfm" => "1.1.0",
"jekyll-commonmark-ghpages" => "0.1.6",

# Misc
Expand Down
6 changes: 6 additions & 0 deletions spec/fixtures/kramdown-parser-gfm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---

# Test

~~Nope~~Yes
2 changes: 1 addition & 1 deletion spec/github-pages/dependencies_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

describe(GitHubPages::Dependencies) do
CORE_DEPENDENCIES = %w(
jekyll kramdown liquid rouge jekyll-sass-converter
jekyll kramdown kramdown-parser-gfm liquid rouge jekyll-sass-converter
github-pages-health-check
).freeze
PLUGINS = described_class::VERSIONS.keys - CORE_DEPENDENCIES
Expand Down
6 changes: 6 additions & 0 deletions spec/github-pages/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ def rm_destination
end
end

context "kramdown-parser-gfm" do
it "converts GFM to HTML" do
expect(contents).to match("<del>Nope</del>Yes")
end
end

context "liquid" do
it "renders liquid templates" do
expect(contents).to match("Value of foo: bar")
Expand Down