Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jekyll to v3.9.0, kramdown to v2.3.0 #704

Merged
merged 3 commits into from Aug 7, 2020
Merged

Conversation

hubot
Copy link
Contributor

@hubot hubot commented Aug 5, 2020

@parkr parkr changed the title Bump jekyll to v3.9.0 Bump jekyll to v3.9.0, kramdown to v2.3.0 Aug 5, 2020
@ashmaroli
Copy link

Shouldn't GHP whitelist the remaining kramdown extensions so that users can opt-in to use them if needed?
In the current state, a user using, say the Coderay highlighter from kramdown v1 will suddenly have lost their code highlighting and will further not be able to load the kramdown-syntax-coderay gem to resolve the issue either.

@parkr
Copy link
Contributor

parkr commented Aug 6, 2020

Shouldn't GHP whitelist the remaining kramdown extensions so that users can opt-in to use them if needed?
In the current state, a user using, say the Coderay highlighter from kramdown v1 will suddenly have lost their code highlighting and will further not be able to load the kramdown-syntax-coderay gem to resolve the issue either.

I'm not sure that's true. The PLUGIN_WHITELIST variable is passed into Jekyll as the whitelist config entry. This is only used in the PluginManager. Since the KramdownParser code does the require-ing itself, the gems do not need to be part of this whitelist variable.

@ashmaroli
Copy link

I see. Thanks for clearing it for me. 👍

@ashmaroli
Copy link

One more question: What if a user would like to continue using kramdown v1 on GitHub Pages?

@parkr
Copy link
Contributor

parkr commented Aug 6, 2020

What if a user would like to continue using kramdown v1 on GitHub Pages?

Since we strictly version everything here, that won't be possible. If a user would like to build their site using other versions, they are welcome to use GitHub Actions!

@parkr parkr mentioned this pull request Aug 6, 2020
@parkr parkr merged commit f8d7345 into master Aug 7, 2020
@parkr parkr deleted the hubot/jekyll-v3-9-0 branch August 7, 2020 14:24
@parkr
Copy link
Contributor

parkr commented Aug 8, 2020

This PR updates Math output from <script type='math/tex; mode=display'> to \[ ... \]. Please make sure your JavaScript library is updated to support \[ ... \].

For context: gettalong/kramdown#626 gettalong/kramdown#651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants