Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events handled by no-useless-passive and require-passive-events #354

Merged
merged 2 commits into from Dec 6, 2022
Merged

Update events handled by no-useless-passive and require-passive-events #354

merged 2 commits into from Dec 6, 2022

Conversation

boris-petrov
Copy link
Contributor

Check:
https://github.com/ignasdamunskis/passive-events-support/blob/65879a4a57a01763c9a8a07a762f60a2ac268f53/src/utils.js#L24

I'm not sure which list is "more correct"... but I guess more is better, right? 😄

@boris-petrov boris-petrov requested a review from a team as a code owner December 5, 2022 17:14
@boris-petrov boris-petrov changed the title Update events handled by no-useless-passive Update events handled by no-useless-passive and require-passive-events Dec 5, 2022
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 👍

@dgreif dgreif merged commit 4893dad into github:main Dec 6, 2022
renovate bot added a commit to WtfJoke/setup-tectonic that referenced this pull request Mar 1, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-github](https://togithub.com/github/eslint-plugin-github)
| [`4.6.0` ->
`4.6.1`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.6.0/4.6.1)
|
[![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.1/compatibility-slim/4.6.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.1/confidence-slim/4.6.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>github/eslint-plugin-github</summary>

###
[`v4.6.1`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.6.1)

[Compare
Source](https://togithub.com/github/eslint-plugin-github/compare/v4.6.0...v4.6.1)

#### What's Changed

- Update events handled by `no-useless-passive` and
`require-passive-events` by
[@&#8203;boris-petrov](https://togithub.com/boris-petrov) in
[github/eslint-plugin-github#354
- feat: `role-supports-aria-props` rule (no `aria-label`-misuse) by
[@&#8203;smockle](https://togithub.com/smockle) in
[github/eslint-plugin-github#362
-   Updated dependencies

#### New Contributors

- [@&#8203;boris-petrov](https://togithub.com/boris-petrov) made their
first contribution in
[github/eslint-plugin-github#354
- [@&#8203;smockle](https://togithub.com/smockle) made their first
contribution in
[github/eslint-plugin-github#362

**Full Changelog**:
github/eslint-plugin-github@v4.6.0...v4.6.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "monthly" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/WtfJoke/setup-tectonic).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1My4yIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants