Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint-plugin-escompat in typescript config #326

Merged
merged 1 commit into from Oct 11, 2022

Conversation

bdragon
Copy link
Contributor

@bdragon bdragon commented Oct 11, 2022

Since upgrading to eslint-plugin-github@4.4.0, linting with the plugin:github/typescript config produces tons of errors indicating that definitions for the eslint-plugin-escompat plugin can't be found:

1:1   error  Definition for rule 'escompat/no-optional-chaining' was not found                                        escompat/no-optional-chaining
1:1   error  Definition for rule 'escompat/no-nullish-coalescing' was not found                                       escompat/no-nullish-coalescing
...

If I modify my downstream project's eslintrc to include plugins: [..., 'escompat', ...] and lint again, the errors go away. I think the issue is that eslint-plugin-escompat is a dependency of the typescript config for estlint-plugin-github but is not included in the config, so the downstream project fails trying to find it. I'm hoping this change will fix it.

@bdragon bdragon requested a review from a team as a code owner October 11, 2022 20:10
@manuelpuyol manuelpuyol merged commit 795b338 into main Oct 11, 2022
@manuelpuyol manuelpuyol deleted the bdragon/ts-use-plugin-escompat branch October 11, 2022 20:41
renovate bot added a commit to WtfJoke/setup-tectonic that referenced this pull request Feb 4, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-github](https://togithub.com/github/eslint-plugin-github)
| [`4.3.7` ->
`4.6.0`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.3.7/4.6.0)
|
[![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.0/compatibility-slim/4.3.7)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-github/4.6.0/confidence-slim/4.3.7)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>github/eslint-plugin-github</summary>

###
[`v4.6.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.6.0)

[Compare
Source](https://togithub.com/github/eslint-plugin-github/compare/v4.5.0...v4.6.0)

#### What's Changed

- Allow wildcard `*.*.*` prefix extension by
[@&#8203;theinterned](https://togithub.com/theinterned) in
[github/eslint-plugin-github#357

**Full Changelog**:
github/eslint-plugin-github@v4.5.0...v4.6.0

###
[`v4.5.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.5.0)

[Compare
Source](https://togithub.com/github/eslint-plugin-github/compare/v4.4.1...v4.5.0)

#### What's Changed

- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.41.0 to 5.42.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#337
- chore(deps-dev): bump eslint from 8.26.0 to 8.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#339
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.41.0 to 5.42.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#338
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.42.0 to 5.42.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#342
- chore(deps-dev): bump chai from 4.3.6 to 4.3.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#341
- bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.42.0 to 5.42.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#340
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.42.1 to 5.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#348
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.42.1 to 5.44.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#349
- chore(deps): bump prettier from 2.7.1 to 2.8.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#347
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.44.0 to 5.45.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#353
- chore(deps-dev): bump eslint from 8.27.0 to 8.29.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#351
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.44.0 to 5.45.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#350
- allow `.server.*` file extension by
[@&#8203;theinterned](https://togithub.com/theinterned) in
[github/eslint-plugin-github#343

#### New Contributors

- [@&#8203;theinterned](https://togithub.com/theinterned) made their
first contribution in
[github/eslint-plugin-github#343

**Full Changelog**:
github/eslint-plugin-github@v4.4.1...v4.5.0

###
[`v4.4.1`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.4.1)

[Compare
Source](https://togithub.com/github/eslint-plugin-github/compare/v4.4.0...v4.4.1)

#### What's Changed

- Use eslint-plugin-escompat in typescript config by
[@&#8203;bdragon](https://togithub.com/bdragon) in
[github/eslint-plugin-github#326
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.39.0 to 5.40.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#327
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.39.0 to 5.40.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#329
- chore(deps-dev): bump mocha from 10.0.0 to 10.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#328
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.40.0 to 5.40.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#334
- chore(deps-dev): bump eslint from 8.25.0 to 8.26.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#333
- chore(deps): bump eslint-plugin-no-only-tests from 3.0.0 to 3.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#332
- chore(deps): bump eslint-plugin-escompat from 3.3.3 to 3.3.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#331
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.40.0 to 5.40.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#330
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.40.1 to 5.41.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#335
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.40.1 to 5.41.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#336

#### New Contributors

- [@&#8203;bdragon](https://togithub.com/bdragon) made their first
contribution in
[github/eslint-plugin-github#326

**Full Changelog**:
github/eslint-plugin-github@v4.4.0...v4.4.1

###
[`v4.4.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v4.4.0)

[Compare
Source](https://togithub.com/github/eslint-plugin-github/compare/v4.3.7...v4.4.0)

#### What's Changed

- chore(deps): bump eslint-plugin-no-only-tests from 2.6.0 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#286
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.30.6 to 5.30.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#285
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.30.6 to 5.30.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#287
- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.0 to 5.0.1
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#288
- chore(deps): bump eslint-plugin-jsx-a11y from 6.6.0 to 6.6.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#289
- chore(deps): bump prettier from 2.6.2 to 2.7.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#264
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.30.7 to 5.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#291
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.30.7 to 5.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#290
- chore(deps-dev): bump eslint from 8.20.0 to 8.21.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#292
- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.1 to 5.0.2
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#293
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.31.0 to 5.32.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#294
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.31.0 to 5.32.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#295
- chore(deps-dev): bump eslint-plugin-eslint-plugin from 5.0.2 to 5.0.3
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#296
- chore(deps): bump jsx-ast-utils from 3.3.2 to 3.3.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#298
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.32.0 to 5.33.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#299
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.32.0 to 5.33.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#300
- chore(deps-dev): bump eslint from 8.21.0 to 8.22.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#297
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.33.0 to 5.33.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#301
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.33.0 to 5.33.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#303
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.33.1 to 5.35.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#306
- chore(deps-dev): bump eslint from 8.22.0 to 8.23.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#305
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.33.1 to 5.35.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#307
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.35.1 to 5.36.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#308
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.35.1 to 5.36.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#309
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.36.1 to 5.36.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#310
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.36.1 to 5.36.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#311
- chore(deps-dev): bump eslint from 8.23.0 to 8.23.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#312
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.36.2 to 5.37.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#313
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.36.2 to 5.37.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#314
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.37.0 to 5.38.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#317
- chore(deps-dev): bump eslint from 8.23.1 to 8.24.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#316
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.37.0 to 5.38.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#315
- Update array-foreach.md by
[@&#8203;rotelloj](https://togithub.com/rotelloj) in
[github/eslint-plugin-github#318
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.38.0 to 5.38.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#319
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.38.0 to 5.38.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#320
- chore(deps): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 5.38.1 to 5.39.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#321
- chore(deps-dev): bump eslint from 8.24.0 to 8.25.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#322
- chore(deps): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 5.38.1 to 5.39.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[github/eslint-plugin-github#323
- Update eslint plugin escompat by
[@&#8203;koddsson](https://togithub.com/koddsson) in
[github/eslint-plugin-github#325

#### New Contributors

- [@&#8203;rotelloj](https://togithub.com/rotelloj) made their first
contribution in
[github/eslint-plugin-github#318

**Full Changelog**:
github/eslint-plugin-github@v4.3.7...v4.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "monthly" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/WtfJoke/setup-tectonic).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS41In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants