Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version of eslint-plugin-import #145

Merged
merged 1 commit into from Nov 3, 2021

Conversation

yuya-takeyama
Copy link
Contributor

@yuya-takeyama yuya-takeyama commented Nov 3, 2021

I don't know why but package.json and package-lock.json look strange.

In the latest release v4.3.3, eslint-plugin-import is set to "^2.24.2":
https://github.com/github/eslint-plugin-github/blob/v4.3.3/package.json#L34
But the version specified in pakage-lock.json is "2.25.2":
https://github.com/github/eslint-plugin-github/blob/v4.3.3/package-lock.json#L954

Also, dependency to typescrpit disappeared by running npm i.
As far as I can see, there is no package depends on typescript.
So I think this is correect.

image

I'm using npm v7.24.2.


I hope that this repo will use dependabot or renovate to reduce manual modifications for dependencies.

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@keithamus keithamus merged commit 319365e into github:main Nov 3, 2021
@yuya-takeyama yuya-takeyama deleted the fix-package-json branch November 3, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants