Merge pull request #146 from github/upstream-changes

Cleanup
github · Nov 16, 2021 · 8c21392 · 8c21392
2 parents 319365e + 2892e64
commit 8c21392
Show file tree

Hide file tree

Showing 6 changed files with 106 additions and 20 deletions.
diff --git a/.flowconfig b/.flowconfig
diff --git a/.prettierignore b/.prettierignore
diff --git a/lib/configs/browser.js b/lib/configs/browser.js
@@ -2,8 +2,10 @@ module.exports = {
   env: {
     browser: true
   },
-  plugins: ['github'],
+  plugins: ['github', 'escompat'],
+  extends: ['plugin:escompat/recommended', 'plugin:escompat/typescript'],
   rules: {
+    'escompat/no-dynamic-imports': 'off',
     'github/async-currenttarget': 'error',
     'github/async-preventdefault': 'error',
     'github/get-attribute': 'error',

diff --git a/lib/configs/typescript.js b/lib/configs/typescript.js
@@ -14,6 +14,8 @@ module.exports = {
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/no-non-null-assertion': 'off'
+    '@typescript-eslint/no-non-null-assertion': 'off',
+    '@typescript-eslint/no-unused-vars': 'error',
+    '@typescript-eslint/explicit-module-boundary-types': 'off'
   }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,6 +28,7 @@
     "@typescript-eslint/eslint-plugin": "^5.1.0",
     "@typescript-eslint/parser": "^5.1.0",
     "eslint-config-prettier": ">=8.0.0",
+    "eslint-plugin-escompat": "^3.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-i18n-text": "^1.0.1",
@@ -50,7 +51,6 @@
     "@github/prettier-config": "0.0.4",
     "eslint": "^8.0.1",
     "eslint-plugin-eslint-plugin": "^2.3.0",
-    "eslint-visitor-keys": "^2.0.0",
     "globals": "^13.7.0",
     "mocha": "^8.3.2"
   }