Python: Allow provenance in additional taint steps #16512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
reviewed
May 16, 2024
There was a problem hiding this comment.
Very nice! Remember to add QLDoc for the step/3 predicate.
Also, should we perhaps discourage the use of step/2 in general, and move towards a scheme where all taint steps have an "explanation" for why they are present (or are there taint steps for which this doesn't make sense)?
I was thinking we could move towards an "all explained" situation incrementally. |
The logic of which steps an `AdditionalTaintStep` has defined is now pushed into the defitnion of `AdditionalTaintStep`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taint steps can have a provenance string that shows up in path explanations. For steps added via the
AdditionalTaintStepclass, this string used to be hardcoded to"AdditionalTaintStep". Now it is possible to overwrite this string.