C#: Use nuget.exe from the executing machine instead of always downlo… #16498
+65
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
buildless/use-nuget-from-path
branch
from
6194154
to
7806030
Compare
tamasvajk
force-pushed
the
buildless/use-nuget-from-path
branch
from
7806030
to
a79105e
Compare
| var exe = "mono"; | ||
| var args = $"{nugetExe} {command}"; | ||
| string exe, args; | ||
| if (RunWithMono) |
There was a problem hiding this comment.
It can be the case that we're on a linux/mac machine, but we need to run nuget instead of mono nuget.exe. In these cases mono nuget would simply fail.
For example, on my machine:
❯ mono /Library/Frameworks/Mono.framework/Versions/Current/Commands/nuget
Cannot open assembly '/Library/Frameworks/Mono.framework/Versions/Current/Commands/nuget': File does not contain a valid CIL image.
because
❯ cat /Library/Frameworks/Mono.framework/Versions/Current/Commands/nuget
#!/bin/sh
exec /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono $MONO_OPTIONS /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/nuget/nuget.exe "$@"
michaelnebel
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ading it