Java: Clean up some instances of getQualifiedName. #16478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
atorralba
reviewed
May 13, 2024
Comment on lines
-35
to
+36
| cached | ||
| pragma[nomagic] |
There was a problem hiding this comment.
Just to be sure: what are the implications of this in terms of performance? Isn't this a bit out of place in an otherwise harmless-looking PR?
There was a problem hiding this comment.
Firstly, cached implies nomagic, so when removing a cached annotation, the smallest possible change is to then also add nomagic, hence the pragma addition. And caching doesn't really make sense in a .ql file - it's not like there's some other query that can reference the predicate, so this was just a drive-by clean-up and should be harmless.
There was a problem hiding this comment.
Ah, I didn't realize it was a query file. TIL cached implies nomagic (it's somewhat obvious in hindsight, actually). Thanks for the explanation!
atorralba
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleaning up some tech debt.