-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data flow: Synthesize parameter return nodes #16394
Merged
Merged
+978
−467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/synth-param-ret-node
branch
3 times, most recently
from
May 6, 2024 12:24
7b3811a
to
c14d652
Compare
hvitved
force-pushed
the
dataflow/synth-param-ret-node
branch
from
May 6, 2024 12:31
c14d652
to
4b024f8
Compare
hvitved
added
the
depends on internal PR
This PR should only be merged in sync with an internal Semmle PR
label
May 6, 2024
aschackmull
reviewed
May 15, 2024
csharp/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
May 15, 2024
java/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
Outdated
Show resolved
Hide resolved
aschackmull
reviewed
May 15, 2024
aschackmull
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hvitved
force-pushed
the
dataflow/synth-param-ret-node
branch
from
May 21, 2024 12:52
11c6dd2
to
bebcd67
Compare
owen-mc
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go and Shared parts LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C#
C++
DataFlow Library
depends on internal PR
This PR should only be merged in sync with an internal Semmle PR
documentation
Go
Java
Ruby
Swift
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds synthetic return nodes for flow that returns from methods via a parameter. For example, in
we would previously have a direct flow step from
[post] c
at (2) to[post] c
at (3), whereas now we first have a step from[post] c
at (2) toc [Return]
at (1), and then fromc [Return]
at (1) to[post] c
at (3).The motivation for adding the extra node is two-fold: Firstly, it may help with generating fewer
subpaths
, and secondly it will be easier to follow flow path explanations (especially when the parameter write happens in a large method).