C#: Base telemetry Api Source/Sink nodes on abstract classes. #16356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCA looks good. |
michaelnebel
added
the
no-change-note-required
michaelnebel
force-pushed
the
csharp/aligntelemetryimplementation
branch
from
76aed36
to
e64a2d6
Compare
hvitved
previously approved these changes
May 6, 2024
|
|
||
| /** | ||
| * Module that adds all API like sinks to `SinkNode`, excluding sinks for cryptography based | ||
| * queries, and queries where sinks are not succifiently defined (eg. using broad method name matching). |
|
|
||
| /** | ||
| * Module that adds all API like sources to `SourceNode`, excluding some sources for cryptography based | ||
| * queries, and queries where sources are not succifiently defined (eg. using broad method name matching). |
hvitved
reviewed
May 6, 2024
| @@ -6,7 +6,7 @@ final class SourceNode = FlowSources::SourceNode; | |||
|
|
|||
| /** | |||
| * Module that adds all API like sources to `SourceNode`, excluding some sources for cryptography based | |||
| * queries, and queries where sources are not succifiently defined (eg. using broad method name matching). | |||
| * queries, and queries where sources are not ntly defined (eg. using broad method name matching). | |||
michaelnebel
force-pushed
the
csharp/aligntelemetryimplementation
branch
from
ba7e827
to
757cf8d
Compare
hvitved
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.