Java: Add Android Gradle Plugin 8 and Spring Boot 3 tests #16336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
smowton/admin/android-8-test
branch
2 times, most recently
from
f5e6951
to
beb3cbc
Compare
mbg
reviewed
May 1, 2024
There was a problem hiding this comment.
Reviewed this as part of the associated, internal PR. Nice to have some integration tests for this! Couple of questions:
- The two new integration tests include the
.gradlefolder. Is that intentional? If so why? Other integration tests that use Gradle don't seem to do this. - It may be useful to add a comment before the use of
try_use_java11()to note why this is necessary. Particularly, it's not immediately obvious what impact this has on the version selection logic and how it affects the test outcome when compared to what may be happening in users' workflows.
| import sys | ||
| import tempfile | ||
|
|
||
| def actions_expose_all_toolchains(): |
There was a problem hiding this comment.
This is a really nice addition for testing!
smowton
force-pushed
the
smowton/admin/android-8-test
branch
from
beb3cbc
to
63fa719
Compare
mbg
approved these changes
May 14, 2024
There was a problem hiding this comment.
Minor: bit odd to have such a comprehensive .gitignore specifically for this test. Consider moving it up to the most distant ancestor of this directory where it makes sense.
There was a problem hiding this comment.
These things are generated by Gradle wrapper installation-- you can see quite a few in the test directories for this reason
smowton
force-pushed
the
smowton/admin/android-8-test
branch
from
4d8e9c1
to
bfb291c
Compare
|
QHelp previews: |
smowton
force-pushed
the
smowton/admin/android-8-test
branch
from
bfb291c
to
942df38
Compare
smowton
force-pushed
the
smowton/admin/android-8-test
branch
from
942df38
to
a50584c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.