JavaScript: Update to TypeScript 4.8 #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
reviewed
Aug 29, 2022
…to the java extractor
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Aug 30, 2022
…ge conflict between github#10202 and github#10184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devblogs.microsoft.com/typescript/announcing-typescript-4-8
The most tricky part was a change to the syntax tree representation.
The
modifiersproperty that we rely on inTypeScriptASTConverter.javamight disappear at a later time.The fix at that point will be to use
ts.canHaveModifiers()andts.getModifiers().TypeScript changed how illegal decorators are stored between 4.8.1-RC and 4.8.2 (this PR). So I had to fix that.
Otherwise it was an uneventful update.
There's not much new, and what's new doesn't affect us, except that we get slightly more precise types from TypeScript.
Evaluation will appear here.