QL: update codeql-action in QL-for-QL #10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
update-ql-for-ql-action
branch
from
425c38e
to
32e3ec0
Compare
erik-krogh
force-pushed
the
update-ql-for-ql-action
branch
8 times, most recently
from
00448bb
to
a72a49b
Compare
erik-krogh
force-pushed
the
update-ql-for-ql-action
branch
3 times, most recently
from
f4604ce
to
28087a5
Compare
erik-krogh
force-pushed
the
update-ql-for-ql-action
branch
from
28087a5
to
b3adb62
Compare
esbena
approved these changes
Aug 22, 2022
| @@ -17,7 +17,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - name: Find codeql | |||
| id: find-codeql | |||
| uses: github/codeql-action/init@aa93aea877e5fb8841bcb1193f672abf6e9f2980 | |||
| uses: github/codeql-action/init@71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca | |||
There was a problem hiding this comment.
Could we point this at a tag to make similar updates simpler.
I.e. create a tag for 71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca on gitub/codeql-action titled v2-with-ql-language, and use that instead of the explicit sha.
There was a problem hiding this comment.
I prefer pinned commits.
In the beginning we had it point to a branch, but then I broke the workflow by updating the branch (the workflow needed updating).
After that I've preferred using a commit SHA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was from back in March.
The updated version of
codeql-actionis the latestmain+ a commit that addsqlas a supported language.I had to update how we do the config file to support the changes that has happened in
codeql-action.