Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change category uniqueness test #872

Merged
merged 3 commits into from Jan 17, 2022
Merged

Commits on Jan 12, 2022

  1. Change category uniqueness test

    Turboscan only allows a single combination of tool name and automation
    details id for testing category uniqueness.
    
    Previously, the check in the action was not entirely correct since it
    only looked at the _category_ and not the combination of the category
    and the tool name.
    
    It's even more precise now since it is looking at the actual, computed
    value of the automation details id, rather than an inputted value of
    the category.
    
    This change also includes a refactoring where the action is now avoiding
    multiple parsing/stringifying of the sarif files. Instead, sarif is
    parsed once at the start of the process and stringified once, after
    sarif processing is completely finished.
    aeisenberg committed Jan 12, 2022
    Copy the full SHA
    8454e21 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Allow duplicate categories in the same validation step

    A single SARIF file should be allowed to have duplicated
    categories.
    aeisenberg committed Jan 13, 2022
    Copy the full SHA
    ab1f709 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Copy the full SHA
    8de62be View commit details
    Browse the repository at this point in the history