Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify config file and out of disk CLI errors as config errors #2297

Merged
merged 2 commits into from
May 20, 2024

Conversation

angelapwen
Copy link
Contributor

This PR classifies CLI errors with "out of disk" and "No space left on device" errors as configuration errors, and appends a link to https://gh.io/troubleshooting-code-scanning/out-of-disk-or-memory to the error.

It also classifies CLI errors related to invalid configuration files as configuration errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner May 15, 2024 21:59
@angelapwen
Copy link
Contributor Author

There are some CI failures due to a new runner image rollout: it will be fixed as of CLI v2.17.3, which will be released shortly, so this PR is probably blocked from merging until then.

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@angelapwen angelapwen merged commit ebd27c0 into main May 20, 2024
296 checks passed
@angelapwen angelapwen deleted the angelapwen/classify-config-errors branch May 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants