Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for merging SARIF files with non-unique categories #2265

Merged
merged 13 commits into from May 3, 2024
Merged

Add deprecation warning for merging SARIF files with non-unique categories #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8b0dfa8
Add deprecation warning for merging SARIF files with non-unique categ…
koesie10 Apr 22, 2024
24acd77
Set correct changelog URL
koesie10 Apr 26, 2024
a5e49d1
Extract check for combine SARIF files deprecation warning
koesie10 Apr 26, 2024
7c29971
Add combine_sarif_files_deprecation_warning_enabled feature flag
koesie10 Apr 26, 2024
80394dc
Hide deprecation warning if feature flag is not set
koesie10 Apr 26, 2024
905f9b0
Only show deprecation warning on GHES 3.14+
koesie10 Apr 26, 2024
b3225af
Mention GHES 3.18 as removal version on GHES
koesie10 Apr 26, 2024
40f70f9
Extract more information message
koesie10 May 2, 2024
757fcd3
Remove unnecessary optional chaining
koesie10 May 2, 2024
1de9b37
Clarify name of function
koesie10 May 2, 2024
725ed41
Add tests for shouldShowCombineSarifFilesDeprecationWarning
koesie10 May 2, 2024
3a471a0
Update comment
koesie10 May 2, 2024
5d274be
Update CodeQL deprecation message
koesie10 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/feature-flags.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/feature-flags.js.map
View file
Open in desktop

Large diffs are not rendered by default.

72 changes: 66 additions & 6 deletions lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/upload-lib.js.map
View file
Open in desktop

Large diffs are not rendered by default.

44 changes: 44 additions & 0 deletions lib/upload-lib.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.