Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-setup: Handle poetry virtualenvs.options.no-pip = true #1431

Merged
merged 8 commits into from Jan 16, 2023
Merged

python-setup: Handle poetry virtualenvs.options.no-pip = true #1431

merged 8 commits into from Jan 16, 2023

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Dec 9, 2022

Fixes #1425

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg
aeisenberg reviewed Dec 12, 2022
View reviewed changes
src/analyze.ts
@@ -88,6 +88,8 @@ async function setupPythonExtractor(logger: Logger) {
return;
}

const scriptsFolder = path.resolve(__dirname, "../python-setup");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rebuild the javascript files in order to get this to pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@RasmusWL RasmusWL force-pushed the rasmuswl/poetry-always-install-pip branch from 0bcae85 to c2e3666 Compare December 15, 2022 14:37
@aeisenberg
Copy link
Contributor

Hmmm...at least one of the failing tests may point to a legitimate problem: https://github.com/github/codeql-action/actions/runs/3705092268/jobs/6278570030#step:7:29

@RasmusWL RasmusWL force-pushed the rasmuswl/poetry-always-install-pip branch from c2e3666 to 4bd9723 Compare January 13, 2023 10:26
@RasmusWL RasmusWL marked this pull request as ready for review January 13, 2023 14:55
@RasmusWL RasmusWL requested review from a team as code owners January 13, 2023 14:55
@RasmusWL
Copy link
Member Author

🤔 maybe I should have not rebased, so the old actions runs were still linked from the commits 🤔 anyway, good that the comment from @aeisenberg links directly to the initial windows failure.

Also 🙈 on the fact that it took this many attempts to get it right

aeisenberg
aeisenberg approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RasmusWL RasmusWL merged commit 32be38e into main Jan 16, 2023
@RasmusWL RasmusWL deleted the rasmuswl/poetry-always-install-pip branch January 16, 2023 08:31
This was referenced Jan 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pip' on github/codeql-action/analyze
2 participants
@RasmusWL @aeisenberg