Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-setup: Don't allow Poetry to make venv in project #1419

Merged
merged 4 commits into from Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions python-setup/auto_install_packages.py
Expand Up @@ -33,10 +33,16 @@ def _check_output(command, extra_env={}):

def install_packages_with_poetry():

# To handle poetry 1.2, which started to use keyring interaction MUCH more, we need
# add a workaround. See
# https://github.com/python-poetry/poetry/issues/2692#issuecomment-1235683370
extra_poetry_env = {"PYTHON_KEYRING_BACKEND": "keyring.backends.null.Keyring"}
extra_poetry_env = {
# To handle poetry 1.2, which started to use keyring interaction MUCH more, we need
# add a workaround. See
# https://github.com/python-poetry/poetry/issues/2692#issuecomment-1235683370
"PYTHON_KEYRING_BACKEND": "keyring.backends.null.Keyring",
# Projects that specify `in-project = true` in their poetry.toml would get the
# venv created inside the repo directory, which would cause CodeQL to consider
# it as user-written code. We don't want this to happen.
"POETRY_VIRTUALENVS_IN_PROJECT": "False",
RasmusWL marked this conversation as resolved.
Show resolved Hide resolved
}

command = [sys.executable, '-m', 'poetry']
if sys.platform.startswith('win32'):
Expand Down
2 changes: 2 additions & 0 deletions python-setup/tests/poetry/requests-3/poetry.toml
@@ -0,0 +1,2 @@
[virtualenvs]
in-project = true