-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby and Swift language autodetect test #1369
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
80d68ec
Add Swift language autodetect test
angelapwen f70f3fd
Merge branch 'main' into swift-autodetect
angelapwen 23c7750
Merge branch 'main' into swift-autodetect
angelapwen b415ca9
Merge branch 'main' into swift-autodetect
angelapwen dfe79c8
Update generated check
angelapwen 11436f9
Remove `TEST_MODE` environment variable
angelapwen 7e70811
Update autogenerated checks
angelapwen 87cd70c
Update multi language autodetect check
angelapwen 541382a
Remove Swift-specific autodetect check
angelapwen c48901b
Remove Ruby autodetect check
angelapwen 93b9fee
Remove if condition for non-Ruby/Swift languages
angelapwen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# This check should be combined into `multi-language-autodetect.yml` once Swift is GA'ed | ||
# and the `CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT` environment variable is not needed. | ||
name: "Swift analysis with language autodetection" | ||
description: "Tests creation of a Swift database when language is not specified in `init`" | ||
versions: ["latest", "cached", "nightly-latest"] | ||
# Swift autobuilder is only supported on MacOS for private beta | ||
operatingSystems: ["macos"] | ||
env: | ||
CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT: "true" | ||
steps: | ||
- uses: ./../action/init | ||
with: | ||
tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
env: | ||
TEST_MODE: true | ||
angelapwen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- uses: ./../action/autobuild | ||
- uses: ./../action/analyze | ||
id: analysis | ||
env: | ||
TEST_MODE: true | ||
angelapwen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: Check database | ||
shell: bash | ||
run: | | ||
SWIFT_DB="${{ fromJson(steps.analysis.outputs.db-locations).swift }}" | ||
if [[ ! -d "$SWIFT_DB" ]]; then | ||
echo "Did not create a database for Swift." | ||
exit 1 | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine to set
CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true
inmulti-language-autodetect.yml
to help cut down on the number of jobs. We could add some checks on the tools version to make sure that language autodetection does the right thing for old CLIs too.