Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node modules PR check with fixed npm version #1357

Closed
wants to merge 5 commits into from
Closed

Update node modules PR check with fixed npm version #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0eee1e9
Add node setup step
angelapwen Nov 10, 2022
d39a4f6
Specify v16.18.0
angelapwen Nov 10, 2022
9a2a2da
Remove setup node Action
angelapwen Nov 10, 2022
259a837
Update package-lock with latest npm version
angelapwen Nov 10, 2022
e42f82e
Add npm update to error message
angelapwen Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/script/check-node-modules.sh
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ npm run removeNPMAbsolutePaths
# Check that repo is still clean
if [ ! -z "$(git status --porcelain)" ]; then
# If we get a fail here then the PR needs attention
>&2 echo "Failed: node_modules are not up to date. Run 'npm ci && npm run removeNPMAbsolutePaths' on a macOS machine to update. Note it is important this command is run on macOS and not any other operating system as there is one dependency (fsevents) that is needed for macOS and may not be installed if the command is run on a Windows or Linux machine."
>&2 echo "Failed: node_modules are not up to date. Run 'npm ci && npm run removeNPMAbsolutePaths' on a macOS machine to update and commit. Note it is important this command is run on macOS and not any other operating system as there is one dependency (fsevents) that is needed for macOS and may not be installed if the command is run on a Windows or Linux machine. If there are no changes, run 'npm install --force -g npm@latest' with root permissions first."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to pin to v8.19.2? I don't think we can move to package-lock v3 while we also need to support node v12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest v8 release (8.19.3) of npm is compatible with Node 12. I think package-lock v3 should be compatible with Node 12 since the package-lock is only consumed by npm

git status
exit 1
fi
Expand Down