Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge releases/v2 into releases/v1 #1314

Merged
merged 41 commits into from Oct 18, 2022
Merged

Commits on Oct 5, 2022

  1. Refactor handling of feature flags

    This commit centralizes how feature flags are handled. All feature flags
    must now add an entry in the `featureFlagConfig` dictionary. This
    dictionary associates the flag with an environment variable name and
    optionally a minimum version for CodeQL.
    
    The new logic is:
    
    - if the environment variable is set to false: disabled
    - if the minimum version requirement specified and met: disabled
    - if the environment variable is set to true: enable
    - Otherwise check feature flag enablement from the server
    aeisenberg committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e5c3375 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Address comments from review

    - Change env var name for `MlPoweredQueriesEnabled`
    - Throw error if minimumVersion is specified, but CodeQL argument is not
      supplied.
    - Fix failing tests. Note that I removed a config-utils test because it
      is no longer relevant since we handle codeql minimum versions in the
      `getValue` function.
    aeisenberg committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    b16314e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6de05e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5915e70 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Extract GitHubFeatureFlags to a separate class

    Internal refactoring so that `GitHubFeatureFlags` is
    private only. The public facing class is `Features`.
    aeisenberg committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    b27aed7 View commit details
    Browse the repository at this point in the history
  2. Mergeback v2.1.27 refs/heads/releases/v2 into main (#1289)

    * Merge main into releases/v2 (#1287)
    
    * Update changelog and version after v2.1.26
    
    * Update checked-in dependencies
    
    * Don't check for Go logs on failure (#1279)
    
    * Update supported GitHub Enterprise Server versions. (#1275)
    
    Co-authored-by: GitHub <noreply@github.com>
    
    * TRAP Caching: Add timeouts to upload/download operations
    
    * Add logging statements declaring state of the cli_config_file_enabled
    
    It's possible to determine this otherwise, but this makes it easier to
    spot.
    
    * Avoid using single value as array
    
    The user config parser in the CLI doesn't yet support it.
    
    * Extract logging statements to separate function
    
    * Correctly report CodeQL version when using cache (#1259)
    
    * Correctly report CodeQL version when using cache
    
    * Add JS generated files
    
    * Add test for return value of `setupCodeQL`
    
    * Fill in missing return value comment
    
    * Convert "Invalid source root" errors to UserErrors
    
    * Add changelog note for Go extraction reconciliation (#1286)
    
    * Add changelog note for Go extraction reconciliation
    
    * Update CHANGELOG.md
    
    Co-authored-by: Henry Mercer <henrymercer@github.com>
    
    * Update CHANGELOG.md
    
    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    
    * Tweaks from PR review
    
    Co-authored-by: Henry Mercer <henrymercer@github.com>
    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    
    * Update changelog for v2.1.27
    
    Co-authored-by: github-actions[bot] <github-actions@github.com>
    Co-authored-by: Chuan-kai Lin <cklin@github.com>
    Co-authored-by: Angela P Wen <angelapwen@github.com>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: GitHub <noreply@github.com>
    Co-authored-by: Edoardo Pirovano <edoardo.pirovano@gmail.com>
    Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com>
    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    Co-authored-by: Henry Mercer <henrymercer@github.com>
    
    * Update changelog and version after v2.1.27
    
    * Update checked-in dependencies
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: github-actions[bot] <github-actions@github.com>
    Co-authored-by: Chuan-kai Lin <cklin@github.com>
    Co-authored-by: Angela P Wen <angelapwen@github.com>
    Co-authored-by: GitHub <noreply@github.com>
    Co-authored-by: Edoardo Pirovano <edoardo.pirovano@gmail.com>
    Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com>
    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    Co-authored-by: Henry Mercer <henrymercer@github.com>
    9 people committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3d39294 View commit details
    Browse the repository at this point in the history
  3. More renaming

    Avoid usage of "Feature Flag" unless we are talking specifically about
    the response from github features api. Otherwise, use terms like
    "Toggleable features".
    
    Note both "toggleable" and "togglable" appear to be valid spellings of
    the word. I chose the first for no good reason.
    aeisenberg committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    1a17c59 View commit details
    Browse the repository at this point in the history
  4. Clarify merging with merge commit (#1291)

    * Clarify merging with merge commit
    
    * Add merge commit message to mergeback PRs
    angelapwen committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c6c7d29 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    919e4ca View commit details
    Browse the repository at this point in the history
  6. Fix typos

    aeisenberg committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6c869f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    6e1dab2 View commit details
    Browse the repository at this point in the history
  2. Update bundle for 2.11.1

    This version has the fix applied
    alexet committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    362f9a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    adb2896 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1294 from github/alexet/release-codeql-2.11.1-v2

    Update bundle for 2.11.1
    alexet committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    c27c6c7 View commit details
    Browse the repository at this point in the history
  5. More renaming

    aeisenberg committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    701cea3 View commit details
    Browse the repository at this point in the history
  6. More feature flag renaming

    henrymercer authored and aeisenberg committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    43c3ed9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #1293 from github/edoardo/fix-with-timeout

    Fix `withTimeout` helper function
    edoardopirovano committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    44edb7c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    082bdf0 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    cc00a9d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1297 from github/update-supported-enterprise-serv…

    …er-versions
    
    Update supported GitHub Enterprise Server versions.
    edoardopirovano committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    099de40 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1296 from github/edoardo/improve-docs

    Improve documentation comment
    edoardopirovano committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e862e8f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    34d48f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    160e3fe View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    2fafb29 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1298 from github/edoardo/caching-hosted

    TRAP Caching: Disable on self-hosted runners
    edoardopirovano committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0c7f674 View commit details
    Browse the repository at this point in the history
  3. Bump @octokit/types from 7.1.1 to 8.0.0

    Bumps [@octokit/types](https://github.com/octokit/types.ts) from 7.1.1 to 8.0.0.
    - [Release notes](https://github.com/octokit/types.ts/releases)
    - [Commits](octokit/types.ts@v7.1.1...v8.0.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@octokit/types"
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2c4b2a1 View commit details
    Browse the repository at this point in the history
  4. Update checked-in dependencies

    github-actions[bot] committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    17ae47e View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1299 from github/dependabot/npm_and_yarn/octokit/…

    …types-8.0.0
    
    Bump @octokit/types from 7.1.1 to 8.0.0
    aeisenberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e2481f7 View commit details
    Browse the repository at this point in the history
  6. Removes deprecated set-output usage

    For more information see
    https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
    
    This change bumps a bunch of the internal actions packages. Note that
    the only required version change is `actions/core` to 1.10.0. The others
    are not required, but seem like a reasonable idea.
    
    It also changes all of the workflows that use `set-output`.
    aeisenberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    eba983f View commit details
    Browse the repository at this point in the history
  7. Update changelog

    aeisenberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2ee8edc View commit details
    Browse the repository at this point in the history
  8. Update CHANGELOG.md

    Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
    aeisenberg and adityasharad committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b0f8861 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge pull request #1301 from github/aeisenberg/remove-set-output

    Removes deprecated set-output usage
    aeisenberg committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    297ec80 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    b709139 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Merge pull request #1310 from github/henrymercer/v2-mergeback

    Mergeback `releases/v2` into `main`
    henrymercer committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    96c8872 View commit details
    Browse the repository at this point in the history
  2. Update changelog for v2.1.28

    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    aecd032 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1311 from github/update-v2.1.28-96c8872f

    Merge main into releases/v2
    edoardopirovano committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    cc7986c View commit details
    Browse the repository at this point in the history
  4. Revert "Update version and changelog for v1.1.27"

    This reverts commit a0e10fe.
    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    80d1f26 View commit details
    Browse the repository at this point in the history
  5. Revert "Update checked-in dependencies"

    This reverts commit 6bb11c6.
    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    b31ec01 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'origin/releases/v2' into update-v1.1.28…

    …-cc7986c0
    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    4a7a948 View commit details
    Browse the repository at this point in the history
  7. Update version and changelog for v1.1.28

    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    6e9376a View commit details
    Browse the repository at this point in the history
  8. Update checked-in dependencies

    github-actions[bot] committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    872f837 View commit details
    Browse the repository at this point in the history