Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for downloading packs from GHES #1221

Merged
merged 14 commits into from Sep 8, 2022
Merged

Add support for downloading packs from GHES #1221

merged 14 commits into from Sep 8, 2022

Commits on Aug 30, 2022

  1. Update changelog

    @aeisenberg
    aeisenberg committed Aug 30, 2022
    Copy the full SHA
    c7bb894 View commit details
    Browse the repository at this point in the history

  2. Add support for downloading packs from GHES 

    This change adds:

- new `registries` block allowed in code scanning config file
- new `registries-auth-tokens` input in init action
- Change the downloadPacks function so that it accepts new parameters:
    - registries block
    - api auth
- Generate a qlconfig.yml file with the registries block if one is
  supplied. Use this file when downloading packs.
- temporarily set the `GITHUB_TOKEN` and `CODEQL_REGISTRIES_AUTH` based
  on api auth

TODO:

1. integration test
2. handle pack downloads when the config is generated by the CLI
    @aeisenberg
    aeisenberg committed Aug 30, 2022
    Copy the full SHA
    0e98efa View commit details
    Browse the repository at this point in the history

  3. Add integration test for using registries-auth-tokens

    @aeisenberg
    aeisenberg committed Aug 30, 2022
    Copy the full SHA
    1d92118 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Change to using a single input

    @aeisenberg
    aeisenberg committed Sep 1, 2022
    Copy the full SHA
    e9b47b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'main' into aeisenberg/ghes-pack-download

    @aeisenberg
    aeisenberg committed Sep 2, 2022
    Copy the full SHA
    b044362 View commit details
    Browse the repository at this point in the history

  2. Convert from json to yaml for registries input

    @aeisenberg
    aeisenberg committed Sep 2, 2022
    Copy the full SHA
    abdf26c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge remote-tracking branch 'upstream/main' into aeisenberg/ghes-pac… 

    …k-download
    @aeisenberg
    aeisenberg committed Sep 6, 2022
    Copy the full SHA
    7e086b2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @aeisenberg
    aeisenberg committed Sep 6, 2022
    Copy the full SHA
    bf97a6d View commit details
    Browse the repository at this point in the history

  3. Clarify description of registries input

    @aeisenberg
    aeisenberg committed Sep 6, 2022
    Copy the full SHA
    376fea6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Gate the new registries input behind version constraints

    @aeisenberg
    aeisenberg committed Sep 7, 2022
    Copy the full SHA
    4fa3e8b View commit details
    Browse the repository at this point in the history

  2. Update changelog and input descriptions

    @aeisenberg
    aeisenberg committed Sep 7, 2022
    Copy the full SHA
    5dcb9de View commit details
    Browse the repository at this point in the history

  3. Only run the init-with-registries check on nightly

    @aeisenberg
    aeisenberg committed Sep 7, 2022
    Copy the full SHA
    aa434aa View commit details
    Browse the repository at this point in the history

  4. Fix unit tests

    @aeisenberg
    aeisenberg committed Sep 7, 2022
    Copy the full SHA
    5974446 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Append / to end of registries url 

    Avoids a bug in 2.10.4. Also, add some better handling for invalid
registries blocks.
    @aeisenberg
    aeisenberg committed Sep 8, 2022
    Copy the full SHA
    6085805 View commit details
    Browse the repository at this point in the history