Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go tracing on Windows, and fix tests #1209

Merged
merged 7 commits into from Aug 24, 2022
Merged

Fix Go tracing on Windows, and fix tests #1209

merged 7 commits into from Aug 24, 2022

Commits on Aug 23, 2022

  1. Fix Go custom tracing tests 

    These were supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than
CODEQL_EXTRACTOR_GO_BUILD_TRACING=on,
therefore tracing wasn't being tested.
    @henrymercer
    henrymercer committed Aug 23, 2022
    Copy the full SHA
    d5ad81b View commit details
    Browse the repository at this point in the history

  2. Warn about invalid value for CODEQL_EXTRACTOR_GO_BUILD_TRACING

    @henrymercer
    henrymercer committed Aug 23, 2022
    Copy the full SHA
    c18ed56 View commit details
    Browse the repository at this point in the history

  3. Disable Lua tracing for Go on Windows 

    This is currently broken in CLI versions 2.10.3 and earlier.
    @henrymercer
    henrymercer committed Aug 23, 2022
    Copy the full SHA
    ab6508a View commit details
    Browse the repository at this point in the history

  4. Add changelog note

    @henrymercer
    henrymercer committed Aug 23, 2022
    Copy the full SHA
    569f78c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Prevent hangs in Go autobuild tests due to .NET keychain prompts

    @henrymercer
    henrymercer committed Aug 24, 2022
    Copy the full SHA
    3069613 View commit details
    Browse the repository at this point in the history

  2. Override CODEQL_EXTRACTOR_GO_BUILD_TRACING with on when it's true

    @henrymercer
    henrymercer committed Aug 24, 2022
    Copy the full SHA
    e195431 View commit details
    Browse the repository at this point in the history

  3. Remove unguarded Actions library query 

    It is enough to pass the checks now that we only use the runner for PR
checks.
    @henrymercer
    henrymercer committed Aug 24, 2022
    Copy the full SHA
    182342c View commit details
    Browse the repository at this point in the history