Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobuild: Update tests for C# on macOS #1149

Merged
merged 8 commits into from Jul 27, 2022
Merged

Commits on Jul 21, 2022

  1. autobuild-action: Run autobuilders with $CODEQL_RUNNER set.

    Without this, the tracer will not be injected on MacOS, as we need the
    runner to circumvent SIP.
    Also add a test that tests the autobuild-action to exercise this code path.
    criemen committed Jul 21, 2022
    Copy the full SHA
    a326649 View commit details
    Browse the repository at this point in the history
  2. Address review.

    criemen committed Jul 21, 2022
    Copy the full SHA
    ceec52c View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Copy the full SHA
    2d2dfa3 View commit details
    Browse the repository at this point in the history
  2. Actions: Fix failing Runner autobuild test on macOS

    Add the missing `$CODEQL_RUNNER` prefix to the autobuild command line.
    This intermediate process works around System Integrity Protection,
    allowing the tracer to start the C# extractor for the dotnet builds
    within the autobuild process.
    
    The test used to pass without this because the legacy CLR tracer bypassed SIP
    while dotnet 5 was used on the Actions virtual environment.
    Now that the virtual environment uses dotnet 6, the CLR tracer no longer works,
    and we need to explicitly work around SIP.
    
    This test will eventually be replaced by an internal integration test for the
    equivalent functionality in the CLI. For now, this change makes the test
    continue to pass.
    adityasharad committed Jul 25, 2022
    Copy the full SHA
    dc1c51d View commit details
    Browse the repository at this point in the history
  3. Actions: Disable the CLR tracer in C# autobuild test

    Ensure that this succeeds even if the legacy CLR tracer is not enabled.
    The combination of the regular tracer and the SIP workaround within Actions
    should be sufficient for this to pass.
    adityasharad committed Jul 25, 2022
    Copy the full SHA
    58faf9d View commit details
    Browse the repository at this point in the history
  4. Autobuild: Remove CODEQL_RUNNER workaround

    We do not need to prefix `$CODEQL_RUNNER` here on macOS to bypass SIP,
    because we assume that the `init` step exported `DYLD_INSERT_LIBRARIES`
    into the environment, which activates the Actions workaround for SIP.
    See actions/runner#416.
    adityasharad committed Jul 25, 2022
    Copy the full SHA
    b4ff463 View commit details
    Browse the repository at this point in the history
  5. Runner tests: Read CODEQL_RUNNER from the stored JSON

    This test workflow does not source the environment from the init step,
    so we need to manually read in the variable.
    adityasharad committed Jul 25, 2022
    Copy the full SHA
    a2f4d66 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Copy the full SHA
    caa2a0d View commit details
    Browse the repository at this point in the history