Merge main into releases/v2 #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit 3ff1fd9.
This avoids creating a __pycache__ folder in the _actions folder, which may cause file ownership problems on self-hosted runners when run in a docker container.
This decorator enabled us to use the functionality of the Actions toolcache within the runner too. Now that we've deleted the runner we no longer need it.
Mergeback v2.1.15 refs/heads/releases/v2 into main
`toolcache.extractTar` currently falls over when `ACTIONS_TEMP` contains a symlink, and the runner no longer exists, so it's unlikely our customers would be running with temporary directories that contain symlinks.
Python-Setup: run auto_install_packages.py with -B flag
This decorator enabled us to use the functionality of the Actions toolcache within the runner too. Now that we've deleted the runner we no longer need it.
This commit prints diagnostic messages to the Actions log when debug logging is enabled by passing `debug: true` to `codeql-action/init` or enabling Actions step debug logging.
…orator Remove toolcache decorator
…ndows Run unit tests on Windows too
The tracer is very good at preserving itself, so unsetting the tracing-specific variables from within a process will not end tracing for children of that process. The way the actions process model works means that we're running inside a process for the entire build step that was launched with the tracer variables set, so we'll have the tracer injected into the entire build step and its children. If we unset the variables in end-tracing, we will get into an intermediate state: Not all variables in there are preserved by the tracer, but the tracer is still active. Usually, that wouldn't be a problem, but the autobuilders called from the finalize step will suddenly run under a half-configured tracer. Particularly, this half-configured tracer is unable to execute the dotnet CLI without hangs, as the environment variable that prevents hangs for dotnet on MacOS has been unset, but the tracer is still active. This is an issue for the the go autobuilder, that invokes user-provided build scripts in the hope of installing dependencies. If that build script then invokes dotnet, it will hang. This is only of concern for the Lua tracer that now implements proper multi-language tracing: Previously, when encountering the go autobuilder, the tracer disabled itself entirely, thus side-stepping any hangs. In the new, multi-language tracing world, the tracer will stay active as long as there is at least one other language that's been set up for tracing. Thus, we also get hangs when invoking the dotnet CLI through the go autobuilder.
…-debug-enabled Print diagnostic messages when debugging mode is enabled
Unset tracing variables after finalizing databases.
Avoid trying to evaluate `github/codeql-action`.
We no longer run this script within Actions for security reasons, and when running locally we can authenticate with the GitHub CLI instead of a PAT.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Enable one-click debugging via the "Enable debug logging" option when re-running Actions jobs
Update required checks: Allow authenticating via the GitHub CLI
This avoids stack overflows when using the spread operator on directories that have many, many children.
Use concat instead of push around `listFolders`
criemen
approved these changes
Jul 13, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 548f07e into releases/v2
Conductor for this PR is @criemen
Contains the following pull requests:
listFolders#1139 - Use concat instead of push aroundlistFolders(@aeisenberg)Please review the following: