Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v2 #1046

Merged
merged 41 commits into from Apr 27, 2022
Merged

Merge main into releases/v2 #1046

merged 41 commits into from Apr 27, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 27, 2022

Merging 7286114 into releases/v2

Conductor for this PR is @hmakholm

Contains the following pull requests:

Please review the following:

  • The CHANGELOG displays the correct version and date.
  • The CHANGELOG includes all relevant, user-facing changes since the last release.
  • There are no unexpected commits being merged into the releases/v2 branch.
  • The docs team is aware of any documentation changes that need to be released.
  • The mergeback PR is merged back into main after this PR is merged.
  • The v1 release PR is merged after this PR is merged.

chrisgavin and others added 30 commits March 30, 2022 12:24
autobuild: add working-directory input
Co-authored-by: Henry Mercer <henrymercer@github.com>
Re-enable waiting for processing by default, using the new API semantics.
The process of creating the v1 release can run into merge conflicts. We
commit the unresolved conflicts so a maintainer can easily resolve them
(vs erroring and requiring maintainers to reconstruct the release
manually).
Prepare for renaming `v1` -> `releases/v1` and `v2` -> `releases/v2`.
Bumps [glob](https://github.com/isaacs/node-glob) from 7.1.7 to 8.0.1.
- [Release notes](https://github.com/isaacs/node-glob/releases)
- [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md)
- [Commits](isaacs/node-glob@v7.1.7...v8.0.1)

---
updated-dependencies:
- dependency-name: glob
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
This check is primarily intended to validate that any merge conflicts in
the v2 -> v1 backport PR are fixed before the PR is merged.
As previously written, if codeql finds a `Pipfile`, but no `Pipfile.lock`, it will run `pipenv install` with args that require `Pipfile.lock` to exist. Pipfile will fail with this message:

```
  Usage: python -m pipenv install [OPTIONS] [PACKAGES]...
  
  ERROR:: Pipfile.lock must exist to use --keep-outdated!
  package installation with pipenv failed, see error above
```

This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus: `--skip-lock` is generally a bit faster.)
Specify releases of the CodeQL Action using tags instead of branches
…ge commit

This gives us slightly messier git history, but more importantly makes
reviewing substantially easier.
@hmakholm hmakholm marked this pull request as ready for review April 27, 2022 17:52
@hmakholm hmakholm requested a review from a team as a code owner April 27, 2022 17:52
@hmakholm hmakholm enabled auto-merge April 27, 2022 17:53
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the changelog and the PRs. Only upcoming docs changes is around the v2 release and that is already being handled.

@hmakholm hmakholm merged commit 7502d6e into releases/v2 Apr 27, 2022
@hmakholm hmakholm deleted the update-v2.1.9-72861144 branch April 27, 2022 18:20
@github-actions github-actions bot mentioned this pull request Apr 27, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants