Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concat instead of push around listFolders #1139

Merged
merged 2 commits into from Jul 13, 2022

Conversation

aeisenberg
Copy link
Contributor

This avoids stack overflows when using the spread operator on directories that have many, many children.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner July 12, 2022 16:15
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. While we're here, perhaps it's worth auditing the rest of the spread operators in the codebase to make sure these aren't likely to cause a stack overflow.

This avoids stack overflows when using the spread operator on
directories that have many, many children.
@aeisenberg
Copy link
Contributor Author

I did a quick look and did not find any other likely dangerous locations.

@aeisenberg aeisenberg merged commit 548f07e into main Jul 13, 2022
@aeisenberg aeisenberg deleted the aeisenberg/concat-not-push branch July 13, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants